-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor imports #157
base: main
Are you sure you want to change the base?
Refactor imports #157
Changes from all commits
26d2d91
e88430c
61efe6c
b77e013
5fe3912
9376ea7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import blog from "../blog.tsx"; | ||
import blog from "../src/blog.tsx"; | ||
|
||
blog({ | ||
author: "Dino", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
{ | ||
"tasks": { | ||
"dev": "deno run --allow-net --allow-read --allow-env=NODE_DEBUG,NO_COLOR,FORCE_COLOR,TERM --watch --no-check ./content/main.tsx --dev", | ||
"test": "deno test --allow-net --allow-read --allow-env=NODE_DEBUG,NO_COLOR,FORCE_COLOR,TERM --no-check=remote", | ||
"serve": "deno run --allow-net --allow-read --allow-env --no-check ./content/main.tsx" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
}, | ||
"imports": { | ||
"@deno/gfm": "jsr:@deno/gfm@^0.10.0", | ||
"@std/testing": "jsr:@std/testing@^1.0.4", | ||
"@std/assert": "jsr:@std/assert@^1.0.7", | ||
"@std/async": "jsr:@std/async@^1.0.8", | ||
"@std/front-matter": "jsr:@std/front-matter@^1.0.5", | ||
"@std/fs": "jsr:@std/fs@^1.0.5", | ||
"@std/http": "jsr:@std/http@^1.0.9", | ||
"@std/path": "jsr:@std/path@^1.0.8", | ||
"@denoland/htm": "https://deno.land/x/[email protected]/mod.ts", | ||
"@denoland/htm/plugins/color-scheme": "https://deno.land/x/[email protected]/plugins/color-scheme.ts", | ||
"@denoland/htm/plugins/unocss": "https://deno.land/x/[email protected]/plugins/unocss.ts", | ||
"@denoland/g_a": "https://deno.land/x/[email protected]/mod.ts", | ||
"@githubcontent/kt3k/callsites": "https://raw.githubusercontent.com/kt3k/callsites/v1.0.0/mod.ts", | ||
"@outdated/std-http": "https://deno.land/[email protected]/http/mod.ts", | ||
Comment on lines
+16
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems weird (but not technically wrong) to give these fake scope names |
||
"feed": "npm:feed@^4.2.2", | ||
"prismjs": "npm:prismjs@^1.29.0", | ||
"remove-markdown": "npm:remove-markdown@^0.5.5" | ||
} | ||
} |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why rename this directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the components are all collated rather than knocking around in the root. Separate them from the configuration files etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to move source under
src/
but the rename istestdata/posts/fifth.md
→content/posts/fifth.md
, presumably calling itcontent
instead oftestdata
has no impact on where the components are located.testdata
is intentionally named for test fixtures.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, thought I saw the comment attached to the above file.
My thought for the rename was that it was a better example of a sensible file name, that users can 'clone and go', But not a hill I would die on, happy to change it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest undoing the
content
change and intead movetestdata
tosrc/testdata