-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor imports #157
Open
thisisjofrank
wants to merge
6
commits into
main
Choose a base branch
from
refactor-imports
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor imports #157
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
26d2d91
refactor files, fix up types, move over to jsr where possible
thisisjofrank e88430c
merge with main
thisisjofrank 61efe6c
update readme
thisisjofrank b77e013
update readme
thisisjofrank 5fe3912
bump action to v2
thisisjofrank 9376ea7
remove deps and esm imports, swap over to npm
thisisjofrank File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import blog from "../blog.tsx"; | ||
import blog from "../src/blog.tsx"; | ||
|
||
blog({ | ||
author: "Dino", | ||
|
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
{ | ||
"tasks": { | ||
"dev": "deno run --allow-net --allow-read --allow-env=NODE_DEBUG,NO_COLOR,FORCE_COLOR,TERM --watch --no-check ./content/main.tsx --dev", | ||
"test": "deno test --allow-net --allow-read --allow-env=NODE_DEBUG,NO_COLOR,FORCE_COLOR,TERM --no-check=remote", | ||
"serve": "deno run --allow-net --allow-read --allow-env --no-check ./content/main.tsx" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
}, | ||
"imports": { | ||
"@deno/gfm": "jsr:@deno/gfm@^0.10.0", | ||
"@std/testing": "jsr:@std/testing@^1.0.4", | ||
"@std/assert": "jsr:@std/assert@^1.0.7", | ||
"@std/async": "jsr:@std/async@^1.0.8", | ||
"@std/front-matter": "jsr:@std/front-matter@^1.0.5", | ||
"@std/fs": "jsr:@std/fs@^1.0.5", | ||
"@std/http": "jsr:@std/http@^1.0.9", | ||
"@std/path": "jsr:@std/path@^1.0.8", | ||
"@denoland/htm": "https://deno.land/x/[email protected]/mod.ts", | ||
"@denoland/htm/plugins/color-scheme": "https://deno.land/x/[email protected]/plugins/color-scheme.ts", | ||
"@denoland/htm/plugins/unocss": "https://deno.land/x/[email protected]/plugins/unocss.ts", | ||
"@denoland/g_a": "https://deno.land/x/[email protected]/mod.ts", | ||
"@githubcontent/kt3k/callsites": "https://raw.githubusercontent.com/kt3k/callsites/v1.0.0/mod.ts", | ||
"@esm/feed": "https://esm.sh/[email protected]", | ||
"@esm/remove-markdown": "https://esm.sh/[email protected]", | ||
"@esm/prism-c": "https://esm.sh/[email protected]/components/prism-c?no-check", | ||
"@outdated/std-http": "https://deno.land/[email protected]/http/mod.ts" | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why rename this directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the components are all collated rather than knocking around in the root. Separate them from the configuration files etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to move source under
src/
but the rename istestdata/posts/fifth.md
→content/posts/fifth.md
, presumably calling itcontent
instead oftestdata
has no impact on where the components are located.testdata
is intentionally named for test fixtures.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, thought I saw the comment attached to the above file.
My thought for the rename was that it was a better example of a sensible file name, that users can 'clone and go', But not a hill I would die on, happy to change it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest undoing the
content
change and intead movetestdata
tosrc/testdata