Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(check): support sloppy imports with "compilerOptions.rootDirs" #27973

Merged
merged 9 commits into from
Feb 5, 2025
Merged

fix(check): support sloppy imports with "compilerOptions.rootDirs" #27973

merged 9 commits into from
Feb 5, 2025
+3,043 −939

Conversation

nayeemrmn
Copy link
Collaborator

Blocked by denoland/deno_config#156.

Fixes #27958.

nayeemrmn
nayeemrmn commented Feb 5, 2025
View reviewed changes
@nayeemrmn nayeemrmn mentioned this pull request Feb 5, 2025
Merged
@nayeemrmn nayeemrmn added this to the 2.2.0 milestone Feb 5, 2025
marvinhagemeister
marvinhagemeister approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the patch stuff is removed.

dsherret
dsherret approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

@nayeemrmn nayeemrmn merged commit bc85548 into denoland:main Feb 5, 2025
18 checks passed
@nayeemrmn nayeemrmn deleted the root-dirs-sloppy-imports branch February 6, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

sloppy resolution across compilerOptions.rootDirs not working
3 participants
@nayeemrmn @marvinhagemeister @dsherret