bulk copy for decimal types #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackielii I appreciate this work. However, I would like to have a full conversation about how decimals are supported end-to-end before doing this. In the mean time feel free to rebase. Depends on #245 |
|
Thanks for responding! Are we going to import apd package and should I wait for that to be included to rebase? I suppose we'll deprecate the internal Decimal type and use the apd package? |
|
@jackielii Feel free to rebase now, I may be able to review it and even without full decimal support. But yes, I'd like to start the conversation on what to do in the driver going forward. No firm plans yet. If you care about this, I'd appreciate some review thought as what to do. |
added 7 commits
April 4, 2017 16:45
jackielii
force-pushed
the
feature/bulkcopy-numeric
branch
from
dd095b2 to
c61ed99
Compare
|
@kardianos rebased |
|
Thanks for the rebase. I'm still planning on looking at this. |
odeke-em
pushed a commit
to orijtech/go-mssqldb
that referenced
this pull request
Jul 26, 2020
Add command to make CLI example with Go toolchain work
odeke-em
pushed a commit
to orijtech/go-mssqldb
that referenced
this pull request
Jul 26, 2020
* exported Github struct fields and ReadDirectory method
* github ee implementation, tests and docs
* build fixes
* Github Enterprise API endpoint based on docs
* addressing PR comments
* code review
* make linter happy
* parseBool() takes fallback
* pr comments
* tweaks to Config{}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decimal types first pass. money types should be the same, but not working for some reason. Submitting decimal types only this time
Reference: https://github.com/Microsoft/mssql-jdbc/blob/master/src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java#L3307