Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting sensitive str handling #38203

Merged
merged 12 commits into from
Jan 16, 2025
Merged

Conversation

JasBeilin
Copy link
Contributor

@JasBeilin JasBeilin commented Jan 16, 2025

Status

  • Ready

Related Issues

Description

Reverting changes due to performance issues.
This was a forced action due to urgency, but the build was actually green except for TPB. I reran a different PR to confirm, and only one test failed, which appears to be unrelated

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Jan 16, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ApiModules/Scripts/GSuiteApiModule
   GSuiteApiModule.py1283275%49–50, 115–118, 141, 201–202, 238–242, 253–254, 256–259, 261, 276–286
Packs/Base/Scripts/CommonServerPython
   CommonServerPython.py469977983%174–177, 188, 190, 427, 469, 565, 591–595, 620, 635, 777–778, 787, 828–829, 847, 877–881, 885–887, 929, 1016–1024, 1068–1073, 1107–1109, 1239–1243, 1246–1247, 1249–1251, 1265–1267, 1269, 1335, 1348, 1361, 1369–1371, 1373, 1386, 1394, 1496–1497, 1552, 1574–1575, 1578, 1584, 1586, 1588, 1682, 1727, 1801–1802, 1806–1807, 1846–1847, 1861–1866, 1868, 1936, 2019, 2021, 2041, 2071, 2075, 2117, 2296, 2320, 2359–2360, 2440–2441, 2443, 2456–2463, 2465, 2542–2544, 2558, 2571, 2602, 2608–2612, 2614–2616, 2618, 2622–2623, 2625, 2638–2644, 2648, 2652–2654, 2660–2661, 2673, 2701, 2704, 2709, 2729, 2735, 2737, 2739, 2759, 2762, 2774, 2820–2828, 2830, 2889, 2911, 2931, 2989, 3001–3002, 3114, 3116, 3318, 3328, 3334, 3343, 3349, 3363, 3419, 3428, 3431, 3434, 3437, 3440, 3443, 3452, 3454, 3459–3460, 3491–3496, 3499, 3550–3551, 3554, 3720–3721, 3724, 3831, 3834, 4085, 4088, 4091, 4094, 4099, 4108, 4134, 4140, 4143, 4149, 4152, 4155, 4158, 4161, 4170, 4172, 4288–4289, 4313, 4315, 4334, 4337, 4340, 4408, 4429, 4431, 4593, 4611, 4623, 4653, 4656, 4662, 4665, 4668, 4677, 4679, 4879–4880, 4899, 4902, 4905, 4908, 4914, 4976, 4978, 5003, 5018–5034, 5037, 5041–5042, 5044–5045, 5047–5048, 5050–5051, 5053–5054, 5056–5057, 5059–5060, 5062–5063, 5065–5066, 5068–5069, 5071–5072, 5074–5075, 5077–5078, 5080, 5082–5083, 5085–5088, 5090–5092, 5094, 5096, 5100, 5176, 5216, 5222, 5224, 5234, 5272, 5277–5278, 5283, 5287–5288, 5290, 5372, 5378, 5471, 5492, 5495–5500, 5508–5514, 5516–5517, 5562, 5575, 5671–5674, 5679, 5682, 5685, 5719, 5722, 5766, 5768, 5770, 5865, 5916, 5998, 6010, 6028, 6068–6069, 6073, 6075, 6109, 6113, 6115, 6117, 6119, 6165, 6169, 6268–6271, 6273, 6286, 6305, 6315, 6321, 6330–6332, 6335–6338, 6353, 6395, 6424, 6427, 6486–6496, 6499, 6509–6510, 6512–6513, 6515–6516, 6521, 6525–6526, 6528, 6565–6568, 6571–6575, 6579, 6587, 6593, 6621, 6650, 6656–6657, 6708, 6728–6729, 6731, 6771–6772, 6779, 6784, 6790, 6803–6804, 6806, 7077–7079, 7098, 7111, 7123, 7151, 7311, 7326, 7391, 7421, 7463–7464, 7476, 7491–7492, 7494–7495, 7497–7498, 7500–7501, 7503–7506, 7508, 7510–7511, 7513, 7592–7593, 7605, 7649–7652, 7654, 7661–7662, 7822, 7877, 7913, 7933, 7935, 8036, 8196–8199, 8201–8203, 8262, 8281–8282, 8294, 8310, 8331–8332, 8334, 8351, 8438, 8452, 8455–8458, 8461, 8464, 8486–8489, 8586, 8605–8606, 8731, 8748–8750, 8786–8788, 8798–8799, 8817, 8849, 8905, 8909–8910, 8924, 8927, 8940–8942, 8945, 9017, 9187–9188, 9268–9269, 9313–9314, 9316, 9319, 9330, 9336–9339, 9341, 9343, 9345–9346, 9462, 9587, 9601, 9604, 9808, 9817, 9883–9884, 9888, 9949–9952, 9954, 9976, 9988, 10084, 10120–10121, 10134, 10147–10152, 10168–10169, 10177–10178, 10191, 10199–10200, 10217–10218, 10232, 10242, 10258, 10269, 10277–10279, 10281, 10307, 10322, 10333, 10351–10352, 10355, 10373, 10376, 10391, 10405, 10411, 10426, 10443, 10455–10463, 10466–10467, 10469, 10484–10486, 10497, 10500, 10589, 10615, 10622, 10666, 10692–10693, 10736, 10738–10740, 10742, 10817, 10826, 10947, 11011, 11015–11016, 11107–11112, 11208–11211, 11302–11304, 11330, 11364, 11414–11415, 11420–11421, 11438, 11524–11526, 11545, 11757, 11874, 11898, 11921, 11946, 11953–11959, 11961, 11963, 12114, 12165–12166, 12168–12175, 12180–12182, 12184, 12186, 12301–12302, 12321, 12359–12360, 12364, 12393–12401, 12403–12404, 12425, 12428, 12430–12431, 12433, 12435, 12437, 12439–12442, 12444, 12446–12447, 12451–12453, 12486, 12550–12551, 12553, 12561, 12570, 12574, 12576–12578, 12581–12582, 12585–12588, 12591, 12594, 12597–12604, 12606, 12617–12620, 12623, 12625–12629, 12631–12633, 12635
Packs/GSuiteAdmin/Integrations/GSuiteAdmin
   GSuiteAdmin.py6412096%393, 474, 577, 1066–1067, 1198, 1201, 1208, 1683–1684, 1694, 1742, 1747, 1896, 1901, 1903, 1981, 1994–1995, 1997
Packs/GSuiteSecurityAlertCenter/Integrations/GSuiteSecurityAlertCenter
   GSuiteSecurityAlertCenter.py2482191%75, 81, 122, 143, 299, 301, 320, 645, 647–648, 650, 662, 665, 711–712, 720–722, 725–727
Packs/GoogleCalendar/Integrations/GoogleCalendar
   GoogleCalendar.py91396%233, 283–284
Packs/GoogleCloudLogging/Integrations/GoogleCloudLogging
   GoogleCloudLogging.py981287%58–59, 82–83, 197, 202–203, 207–208, 232–233, 236
Packs/GoogleDrive/Integrations/GoogleDrive
   GoogleDrive.py6238586%535–540, 558–561, 563, 662, 679, 708, 879, 882–888, 890, 894, 1005, 1092, 1206, 1209–1210, 1212, 1264, 1266–1273, 1288–1289, 1291–1293, 1298, 1346, 1348, 1350, 1352, 1354, 1363, 1368, 1408–1409, 1411–1413, 1416, 1422, 1428, 1432, 1436, 1438, 1440, 1442, 1447–1448, 1450, 1466–1468, 1470, 1482, 1646, 1648, 1650–1651, 1653, 1657, 1663, 1669, 1693–1694, 1911, 1913
Packs/GsuiteAuditor/Integrations/GsuiteAuditor
   GsuiteAuditor.py653152%42, 105–108, 110, 115, 118, 131–134, 136–137, 187–188, 190, 192–193, 196, 198, 200–201, 203, 205–207, 209–210, 213–214
TOTAL659398385% 

Tests Skipped Failures Errors Time
3711 64 💤 0 ❌ 0 🔥 2m 40s ⏱️

@yuvalbenshalom yuvalbenshalom merged commit 4839a69 into master Jan 16, 2025
14 of 16 checks passed
@yuvalbenshalom yuvalbenshalom deleted the reverting_sensitive_str branch January 16, 2025 22:31
@RosenbergYehuda RosenbergYehuda added the ForceMerge Forcing the merge of the PR despite the build status label Jan 16, 2025
sdaniel6 pushed a commit that referenced this pull request Jan 27, 2025
* fixing performance issue

* RN

* fix

* fix

* wip

* fix

* wip

* remove gsuite

* remove test

* remove lats func

* rn

* pre commit

---------

Co-authored-by: yrosenberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants