Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SaasSecuriy Fixed test button bad request error #38187

Merged
merged 10 commits into from
Jan 24, 2025

Conversation

MosheEichler
Copy link
Contributor

@MosheEichler MosheEichler commented Jan 16, 2025

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-45922

Description

Fixed the get_access_token function request from query params to body params as shown in this example.

Must have

  • Tests
  • Documentation

@MosheEichler MosheEichler added the release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process label Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/PrismaSaasSecurity/Integrations/SaasSecurity
   SaasSecurity.py2583387%193, 264–269, 271–272, 304, 358–359, 362, 406, 485–486, 491, 518–519, 522–523, 526, 531, 626–627, 689, 694–695, 697–698, 701, 703–704
TOTAL2583387% 

Tests Skipped Failures Errors Time
26 1 💤 0 ❌ 0 🔥 2.532s ⏱️

@ShirleyDenkberg
Copy link
Contributor

@thefrieddan1 @sapirshuker Doc review completed.

@MosheEichler MosheEichler requested review from yuvalbenshalom and removed request for thefrieddan1 and sapirshuker January 22, 2025 20:19
@MosheEichler
Copy link
Contributor Author

Test passed successfully

@MosheEichler MosheEichler merged commit 3e71451 into master Jan 24, 2025
17 checks passed
@MosheEichler MosheEichler deleted the SaasSecuriy-fixed-test-button branch January 24, 2025 01:41
sdaniel6 pushed a commit that referenced this pull request Jan 27, 2025
* Fixed test button SaasSecurity

* RN

* Add is_mockable false

* Fixed RN

* add sections

* empty commit

---------

Co-authored-by: Sapir Shuker <[email protected]>
Co-authored-by: sapirshuker <[email protected]>
OneToughMonkey pushed a commit to OneToughMonkey/demisto-content that referenced this pull request Jan 27, 2025
* Fixed test button SaasSecurity

* RN

* Add is_mockable false

* Fixed RN

* add sections

* empty commit

---------

Co-authored-by: Sapir Shuker <[email protected]>
Co-authored-by: sapirshuker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants