Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add 'cloud' feature to 'core' to enable 'cloud' on 'object_store' only when needed #3332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zeevm
Copy link

@zeevm zeevm commented Mar 16, 2025

Description

This new feature in 'core' allows only enabling 'cloud' on 'object_store' when user enabled azure/s3/gcp/lakefs

Related Issue(s)

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Mar 16, 2025
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@zeevm zeevm changed the title Add 'cloud' feature to 'core' to enable 'cloud' on 'object_store' only when needed refactor: Add 'cloud' feature to 'core' to enable 'cloud' on 'object_store' only when needed Mar 16, 2025
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.17%. Comparing base (8acfa3f) to head (7e3cf73).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3332      +/-   ##
==========================================
- Coverage   72.18%   72.17%   -0.02%     
==========================================
  Files         144      144              
  Lines       45822    45822              
  Branches    45822    45822              
==========================================
- Hits        33077    33070       -7     
- Misses      10655    10657       +2     
- Partials     2090     2095       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ion-elgreco ion-elgreco enabled auto-merge March 17, 2025 06:51
@@ -12,7 +12,7 @@ repository.workspace = true
rust-version.workspace = true

[dependencies]
deltalake-core = { version = "0.25.0", path = "../core" }
deltalake-core = { version = "0.25.0", path = "../core", features = ["cloud"] }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

auto-merge was automatically disabled March 18, 2025 08:07

Head branch was pushed to by a user without write access

@zeevm zeevm force-pushed the zeevm/add_cloud_feature branch from 3ea8101 to 7e3cf73 Compare March 18, 2025 08:07
@zeevm zeevm changed the title refactor: Add 'cloud' feature to 'core' to enable 'cloud' on 'object_store' only when needed refactor: add 'cloud' feature to 'core' to enable 'cloud' on 'object_store' only when needed Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't enable "cloud" feature on object_store by default
3 participants