refactor: add 'cloud' feature to 'core' to enable 'cloud' on 'object_store' only when needed #3332
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeevm
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
zeevm
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3332 +/- ##
==========================================
- Coverage 72.18% 72.17% -0.02%
==========================================
Files 144 144
Lines 45822 45822
Branches 45822 45822
==========================================
- Hits 33077 33070 -7
- Misses 10655 10657 +2
- Partials 2090 2095 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ion-elgreco
approved these changes
Mar 17, 2025
natinimni
reviewed
Mar 17, 2025
| @@ -12,7 +12,7 @@ repository.workspace = true | |||
| rust-version.workspace = true | |||
|
|
|||
| [dependencies] | |||
| deltalake-core = { version = "0.25.0", path = "../core" } | |||
| deltalake-core = { version = "0.25.0", path = "../core", features = ["cloud"] } | |||
Signed-off-by: Ze'ev Maor <[email protected]>
auto-merge was automatically disabled
March 18, 2025 08:07
Head branch was pushed to by a user without write access
zeevm
force-pushed
the
zeevm/add_cloud_feature
branch
from
3ea8101 to
7e3cf73
Compare
zeevm
changed the title
|
@ion-elgreco anything else required to finish merging this change? |
Nope, merging was simply blocked because the pr name was invalid before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This new feature in 'core' allows only enabling 'cloud' on 'object_store' when user enabled azure/s3/gcp/lakefs
Related Issue(s)