refactor: flatten deeply nested match statement #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
=======================================
Coverage 84.38% 84.39%
=======================================
Files 80 80
Lines 19222 19219 -3
Branches 19222 19219 -3
=======================================
- Hits 16220 16219 -1
+ Misses 2200 2197 -3
- Partials 802 803 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OussamaSaoudi
approved these changes
Mar 20, 2025
| } | ||
| DataType::Map { .. } => unimplemented!(), | ||
| }, | ||
| Null(DataType::BYTE) => Arc::new(Int8Array::new_null(num_rows)), |
There was a problem hiding this comment.
Is it worth factoring out all the Arc::news?
There was a problem hiding this comment.
Can't -- each Arc::new call produces Arc<T: Array> for a different T, that immediately decays to the Arc<dyn Array> we actually want.
sebastiantia
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Small code readability improvement -- instead of a triple-nested match, flatten it out to a single level.
How was this change tested?
Existing unit tests. No new functionality.