Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split up arrow_expression module #750

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

maruschin
Copy link
Contributor

@maruschin maruschin commented Mar 19, 2025

What changes are proposed in this pull request?

Split arrow_expression.rs into a dedicated submodule.
Move tests and utility functions to separate files for better organization and maintainability.
This solves the issue 745.

How was this change tested?

existing UT

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: Github did not detect that the code was moved. So I manually diffed each new file against the original to detect any changes made during code movement, e.g.:

git diff -b maruschin/split_up_arrow_expression~1:kernel/src/engine/arrow_expression.rs maruschin/split_up_arrow_expression:kernel/src/engine/arrow_expression/tests.rs

Everything looks good except a few private functions that should be changed to pub(crate) instead of pub.

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 85.17350% with 94 lines in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (34b9d1a) to head (5e8987e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/engine/arrow_expression/mod.rs 55.00% 36 Missing and 9 partials ⚠️
...src/engine/arrow_expression/evaluate_expression.rs 82.82% 15 Missing and 13 partials ⚠️
kernel/src/engine/arrow_expression/apply_schema.rs 82.64% 13 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   84.39%   84.38%   -0.01%     
==========================================
  Files          77       80       +3     
  Lines       19226    19222       -4     
  Branches    19226    19222       -4     
==========================================
- Hits        16225    16220       -5     
- Misses       2198     2200       +2     
+ Partials      803      802       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks! Do change the visibility things scovich flagged, and maybe write a bit more of a description (as that's what will end up in the git history).

Otherwise looks great, thanks.

@roeap roeap linked an issue Mar 19, 2025 that may be closed by this pull request
@maruschin maruschin force-pushed the split_up_arrow_expression branch 2 times, most recently from f3280ec to 56a882b Compare March 20, 2025 04:15
@maruschin maruschin changed the title [WIP] Split up arrow_expression Split up arrow_expression Mar 20, 2025
Move tests and utility functions to separate files for better organization and maintainability.
@maruschin maruschin force-pushed the split_up_arrow_expression branch from 56a882b to a31a539 Compare March 20, 2025 05:08
@maruschin
Copy link
Contributor Author

Corrected all comments.

@zachschuermann zachschuermann changed the title Split up arrow_expression refactor: split up arrow_expression module Mar 20, 2025
Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@nicklan nicklan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for your contribution

@nicklan nicklan merged commit 72bab02 into delta-io:main Mar 20, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

split up arrow_expression.rs
4 participants