fix: allow for Null(DataType) equivalency comparison #729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change made in
e2378a579790172800d91701c143f4522957a9de
modified the equivalency behaviors of Scalars in a way that mean Null(DataType::String) != Null(DataType::String) which I don't believe is correct since we can perform an equivalency on the DataType.This changes re-introduces that support with a test case that passes on v0.6.1 and fails on v0.7.0, v0.8.0, and
main
.