Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf!: replace default engine JSON reader's FileStream with concurrent futures #711

Merged
merged 39 commits into from
Mar 3, 2025
Merged
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
ea417b5
let's see
nicklan Feb 21, 2025
504b20c
support --all-features again
nicklan Feb 21, 2025
c217abc
revert
nicklan Feb 21, 2025
8926729
workflows use --all-features again
nicklan Feb 21, 2025
04cdd68
Merge branch 'main' into fix-semvar-check
nicklan Feb 21, 2025
4aa86aa
wip: simple buffered streams
zachschuermann Feb 21, 2025
b0869fc
into_iter
zachschuermann Feb 21, 2025
ffed827
Merge remote-tracking branch 'upstream/main' into concurrent-json
zachschuermann Feb 21, 2025
0cd0cf3
cleaner selection + readme
nicklan Feb 21, 2025
85ebcb8
also for parquet.rs
nicklan Feb 21, 2025
ae8c559
add a `need_arrow` flag
nicklan Feb 22, 2025
22394c8
Merge branch 'main' into fix-semvar-check
nicklan Feb 22, 2025
ce2667f
Merge remote-tracking branch 'nick/fix-semvar-check' into concurrent-…
zachschuermann Feb 24, 2025
1f2f79c
Merge branch 'main' into concurrent-json
zachschuermann Feb 24, 2025
9862a3a
Merge remote-tracking branch 'refs/remotes/origin/concurrent-json' in…
zachschuermann Feb 24, 2025
bc16927
Merge remote-tracking branch 'upstream/main' into concurrent-json
zachschuermann Feb 25, 2025
971ed43
make Json opener async fn and add test
zachschuermann Feb 25, 2025
1a14f90
fmt
zachschuermann Feb 25, 2025
811cc2e
fix comments
zachschuermann Feb 25, 2025
494a470
cleanup
zachschuermann Feb 25, 2025
ba09853
comments and add warn for error
zachschuermann Feb 25, 2025
5ab75c4
address feedback
zachschuermann Feb 25, 2025
f6f5729
add with_buffer_size and deprecate the readahead one
zachschuermann Feb 25, 2025
df7a819
add deterministic test via OrderedGetStore
zachschuermann Feb 27, 2025
f0270c7
clean up imports
zachschuermann Feb 27, 2025
14e1288
combine keys and wakers under one lock
zachschuermann Feb 27, 2025
968926a
address feedback
zachschuermann Feb 27, 2025
baf04d0
better test_read_json_files_ordering
zachschuermann Feb 27, 2025
e05fdfa
fix docs
zachschuermann Feb 28, 2025
5063f8c
revert small changes
zachschuermann Feb 28, 2025
3316d8d
address feedback
zachschuermann Feb 28, 2025
2cff468
comment
zachschuermann Feb 28, 2025
751e582
add small buffer test
zachschuermann Feb 28, 2025
69284d2
flatmap
zachschuermann Feb 28, 2025
8551bca
fix
zachschuermann Feb 28, 2025
1e6f746
Merge branch 'main' into concurrent-json
zachschuermann Mar 1, 2025
e11dc01
remove 'with_readahead'
zachschuermann Mar 3, 2025
d00503f
Merge remote-tracking branch 'refs/remotes/origin/concurrent-json' in…
zachschuermann Mar 3, 2025
f390be1
Merge branch 'main' into concurrent-json
zachschuermann Mar 3, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion feature-tests/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
/// This is a compilation test to ensure that the default-engine feature flags are working
/// correctly. Run (from workspace root) with:
/// correctly.
///
/// Run (from workspace root) with:
/// 1. `cargo b -p feature_tests --features default-engine-rustls`
/// 2. `cargo b -p feature_tests --features default-engine`
///
/// These run in our build CI.
pub fn test_default_engine_feature_flags() {
#[cfg(any(feature = "default-engine", feature = "default-engine-rustls"))]
Expand Down
1 change: 1 addition & 0 deletions kernel/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -159,3 +159,4 @@ tracing-subscriber = { version = "0.3", default-features = false, features = [
"env-filter",
"fmt",
] }
async-trait = "0.1" # only used for our custom SlowGetStore ObjectStore implementation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: keep alphabetical.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved up, to after our path-based deps but on top of others, though they aren't in order it doesn't look like..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah right, we should actually alphabatize those at some point :)

Loading
Loading