Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Streaming iterator to fix the snapshot creation issue #515

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
Minor code cleanup in VersionGroupingIterator
Changes:
- Remove redundant type annotation for version variable
- Fix duplicate #[test] attribute in test_single_commit
hackintoshrao committed Nov 26, 2024
commit 152697c9316d381f38404ef48c60965bbb17d4bd
3 changes: 1 addition & 2 deletions kernel/src/grouping_iterator.rs
Original file line number Diff line number Diff line change
@@ -48,7 +48,7 @@ impl<L: AsUrl> Iterator for VersionGroupingIterator<L> {

fn next(&mut self) -> Option<VersionGroup<L>> {
while let Some(logpath) = self.files.next() {
let version: u64 = logpath.version;
let version = logpath.version;
let mut files = vec![logpath];
// this is where we look ahead for the next file and check if it has the same version
// if it does, we add it to the current group
@@ -108,7 +108,6 @@ mod tests {
ParsedLogPath::try_from(url).unwrap().unwrap()
}

#[test]
/// Tests the basic functionality of VersionGroupingIterator with a single commit file
///
/// This test verifies that: