Remove tf.function in gradient operator to avoid multiple useless retracings #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tf.function decorator on the gradient function was slowing down because of multiple retracings. Removing it speeds up the computation. Adding tf.function on ODIN `input_perturbation()` function was the fastest option but input_perturbation() is not framework-agnostic anymore.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tf.function decorator on the gradient function operator was slowing down because of multiple retracings. Removing it speeds up the computation.
Adding tf.function on ODIN
input_perturbation()function was the fastest option but input_perturbation() would not be framework-agnostic anymore.As a temporary hotfix, we remove
@tf.functiondecorator fromgradientmethod to prevent useless raytracing. We will work on a more long-term solution in a future PR (see issue #52) .