Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue-20] Add stuff for CI #22

Merged
merged 6 commits into from
Feb 4, 2025
Merged

[Issue-20] Add stuff for CI #22

merged 6 commits into from
Feb 4, 2025

Conversation

deeheber
Copy link
Owner

@deeheber deeheber commented Feb 4, 2025

Changes

  • add Github action CI workflow file
  • add eslint configs + dependencies
  • add prettier dependencies
  • edit some npm scripts
  • add recommended settings files in .vscode for vscode users

fixes #20

@deeheber deeheber requested a review from Copilot February 4, 2025 20:01
Copilot
Copilot AI reviewed Feb 4, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.

Files not reviewed (3)
  • .vscode/extensions.json: Language not supported
  • .vscode/settings.json: Language not supported
  • package.json: Language not supported

.github/workflows/ci.yml

steps:
- name: checkout
uses: actions/checkout@v4
Copy link
Preview

Copilot AI Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version 'v4' for 'actions/checkout' does not exist. It should be 'v3'.

Suggested change
uses: actions/checkout@v4
uses: actions/checkout@v3

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol. You are trained on old data.

@deeheber deeheber merged commit c5e8073 into main Feb 4, 2025
1 check passed
@deeheber deeheber deleted the issue-20 branch February 4, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI
1 participant
@deeheber