Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed clock from OutdatedSampleEncoder #16

Draft
wants to merge 6 commits into
base: pp
Choose a base branch
from
Draft

Removed clock from OutdatedSampleEncoder #16

wants to merge 6 commits into from

Conversation

gshigin
Copy link
Collaborator

@gshigin gshigin commented Mar 26, 2025

  • Removed clock dependency from OutdatedSampleEncoder, delegating merge logic to the caller.
  • Updated tests to reflect the new behavior.

@gshigin gshigin requested a review from cherep58 March 26, 2025 06:31
@gshigin gshigin self-assigned this Mar 26, 2025
@gshigin gshigin requested a review from vporoshok as a code owner March 26, 2025 06:31
@gshigin gshigin changed the title completely remove clock from OutdatedSampleEncoder Removed clock from OutdatedSampleEncoder Mar 26, 2025
@gshigin gshigin force-pushed the encoder-remove-clock branch from 7fb859d to 31ca4f7 Compare March 27, 2025 07:30
@gshigin gshigin marked this pull request as draft March 27, 2025 09:00
@gshigin
Copy link
Collaborator Author

gshigin commented Mar 27, 2025

This pull request requires changes on the Go side to trigger chunk merge by a timer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherep58 cherep58 cherep58 approved these changes

@vporoshok vporoshok Awaiting requested review from vporoshok vporoshok is a code owner

Assignees

@gshigin gshigin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gshigin @cherep58