Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest: extract elements instead of matching #199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jkoelker
Copy link
Contributor

@jkoelker jkoelker commented Aug 21, 2020

If the host has old style VIPs, then the matching will fail, instead
just extract the first two elements regardless of the length.

dcos/dcos#7568

If the host has old style VIPs, then the matching will fail, instead
just extract the first two elements regardless of the length.
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #199 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   66.02%   66.05%   +0.02%     
==========================================
  Files          55       55              
  Lines        3759     3759              
==========================================
+ Hits         2482     2483       +1     
+ Misses       1277     1276       -1     
Flag Coverage Δ
#ct 46.02% <ø> (+0.02%) ⬆️
#ct2 46.02% <ø> (+0.02%) ⬆️
#eunit 24.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/dcos_rest/src/dcos_rest_vips_handler.erl 45.00% <ø> (ø)
apps/dcos_l4lb/src/dcos_l4lb_mgr.erl 78.86% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d35033b...63cc66a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant