-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mesos basic auth #169
base: master
Are you sure you want to change the base?
add mesos basic auth #169
Conversation
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
- Coverage 67.94% 67.92% -0.02%
==========================================
Files 55 55
Lines 3584 3588 +4
==========================================
+ Hits 2435 2437 +2
- Misses 1149 1151 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 66.00% 66.01%
=======================================
Files 55 55
Lines 3759 3763 +4
=======================================
+ Hits 2481 2484 +3
- Misses 1278 1279 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@andreaspeters, thanks a lot for your contribution! It is preferred not to supply individual configuration values through environment variables. Please refer to https://github.com/dcos/dcos-net/blob/master/apps/dcos_net/src/dcos_net_app.erl#L45 to learn more about the way By default, |
Hi @ichernetsky , thanks for your response. |
Merge with main
This PR will add the basic auth method to authenticate against the mesos master. Then the nice DC/OS net is also useful for "normal" mesos installations without authentication token. The authentication string have to be in a env variable and should looks like
MESOS_BASIC_AUTH="Basic <BASE64STRING>"
.