Add support to pass in typed group by #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevonFulcher
force-pushed
the
Add_support_to_pass_in_typed_metrics_&_group_by
branch
6 times, most recently
from
e412122 to
27d2b68
Compare
DevonFulcher
force-pushed
the
Add_support_to_pass_in_typed_metrics_&_group_by
branch
4 times, most recently
from
cf3ef2d to
99f803b
Compare
DevonFulcher
changed the title
DevonFulcher
force-pushed
the
Add_support_to_pass_in_typed_metrics_&_group_by
branch
11 times, most recently
from
bd029e2 to
f66caf6
Compare
DevonFulcher
force-pushed
the
Add_support_to_pass_in_typed_metrics_&_group_by
branch
from
7204e95 to
7455034
Compare
serramatutu
approved these changes
Apr 4, 2025
There was a problem hiding this comment.
@DevonFulcher this is awesome! Thank you for the contribution!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the grain option to the group by field. This makes it easier to define a grain without using dunder syntax.