-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dbt gatekeeper cert #98
Draft
kensukemorris
wants to merge
17
commits into
dbt-labs:main
Choose a base branch
from
octoenergy:kensuke-dbt-gatekeeper-practice
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Dbt gatekeeper cert #98
kensukemorris
wants to merge
17
commits into
dbt-labs:main
from
octoenergy:kensuke-dbt-gatekeeper-practice
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temp .gitignore Update README Update readme Pip and make Add profiles template
Add tests for fixing repo
Update guidance
Not needed for this repo and causing dependency conficts
Remove sqlfluff
Signed-off-by: Joanna Lau <[email protected]>
Update pytests
Here are the fixes that need implementing: 1. All .yml files should be renamed to specify what they apply to. 2. Staging models should be split by which source they are coming from. 3. stg_customers contains PII data in the first_name and last_name columns so these need to be hashed. 4. The customers.sql and orders.sql models moced to warehouse folder 5. dbt_project_evaluator_exceptions.csv to make an except for stg_customers referecing stg_customers_pii
Finance - Total value of orders returned by customer Sales - The customer count by month for customers making their first order
kensukemorris
force-pushed
the
kensuke-dbt-gatekeeper-practice
branch
from
December 5, 2023 11:36
f62eb32
to
0e2df17
Compare
kensukemorris
force-pushed
the
kensuke-dbt-gatekeeper-practice
branch
from
December 6, 2023 03:18
88e638b
to
34b3bcf
Compare
kensukemorris
force-pushed
the
kensuke-dbt-gatekeeper-practice
branch
from
December 6, 2023 03:24
34b3bcf
to
5410337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.