adjust reporter to not import entire @datadog/datadog-api-client #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kroney Is there a problem this is solving? |
|
Right now we're always importing v1, v2 and client, which are all huge packages. My hope is that with this fix, the package can be better treeshaken |
|
Ah, I feel your pain there. But this would have to move to ESM syntax to get that kind of tree-shaking. A better solution to this particular issue is probably #132 and #144. (I started those near the end of last year, but some other things came up and I have not had time to return to them. I have not prioritized them since nobody has commented.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.