-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test(markdownlint): doesn't provide correct results (#254)
* fix: markdownlint glob declaration * fix: corrected that URL * refactor: aligned indentation * chore: need to ignore output files * refactor: ignoring this rule at line * test(markdownlint): using the default rules
- Loading branch information
Showing
5 changed files
with
15 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
node_modules | ||
CHANGELOG.md | ||
build/** | ||
out/** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
# How to create and provide the technical icon files | ||
|
||
We're getting these icons by the [DB Design System colleagues](https://dbsw-my.sharepoint.com/personal/maximilian_franzke_deutschebahn_com/_layouts/15/onedrive.aspx?id=%2Fteams%2FCXM%2ETeams%2DDDSTeam%2FShared%20Documents%2FDDS%20Team%2F01%2D%2DDesign%2DSystem%2F04%2D%2DFoundations%2F07%2D%2DIcons%2F04%2D%2DExchange%2DIcons%2F01%2D%2DFunctional&listurl=https%3A%2F%2Fdbsw%2Esharepoint%2Ecom%2Fteams%2FCXM%2ETeams%2DDDSTeam%2FShared%20Documents&viewid=0595d7bc%2Db96a%2D483a%2D8d53%2D87b3356ce9fc) and process the following changes: | ||
We're getting these icons by the [DB Design System colleagues](https://dbsw.sharepoint.com/:f:/r/teams/CXM.Teams-DDSTeam/Shared%20Documents/DDS%20Team/01--Design-System/04--Foundations/07--Icons/04--Exchange-Icons?csf=1&web=1&e=hzdDGu) and process the following changes: | ||
|
||
- Minifications with [`ImageOptim`](https://imageoptim.com/mac) | ||
- Adding some contents within the SVGs (these assets might get exported correctly in the future) | ||
- CSS variables (replace `fill="#282D37"` by `fill="#282D37" style="fill: currentColor;fill: var(--db-icon-color, currentColor)"`) | ||
- `id`-Attribute (generic `icon` id within all SVG files) | ||
- Afterwards the JSON files within the `source/_patterns/icons` path might need to get updated | ||
- Minifications with [`ImageOptim`](https://imageoptim.com/mac) | ||
- Adding some contents within the SVGs (these assets might get exported correctly in the future) | ||
- CSS variables (replace `fill="#282D37"` by `fill="#282D37" style="fill: currentColor;fill: var(--db-icon-color, currentColor)"`) | ||
- `id`-Attribute (generic `icon` id within all SVG files) | ||
- Afterwards the JSON files within the `source/_patterns/icons` path might need to get updated |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters