Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using author_names to get the author names #30

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Switch to using author_names to get the author names #30

merged 2 commits into from
Feb 4, 2025

Conversation

davep
Copy link
Owner

@davep davep commented Feb 4, 2025

Closes #29.

@davep davep added Enhancement New feature or request TODO A thing I'm planning on doing labels Feb 4, 2025
@davep davep self-assigned this Feb 4, 2025
@davep davep marked this pull request as ready for review February 4, 2025 06:40
@davep davep merged commit 03ccccc into main Feb 4, 2025
5 checks passed
@davep davep deleted the use-auhors-list branch February 4, 2025 06:43
davep added a commit that referenced this pull request Feb 4, 2025
@davep
🔨 Add the authors property back
cda7494 
Following on from #30: I'd commented this out for a moment so I could easily
find all the code that referenced this field and swap it over to
`author_names`, and then I forgot to put it back before merging #30.
@davep davep mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davep davep

Labels
Enhancement New feature or request TODO A thing I'm planning on doing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swap to using author_names rather than the janky authors splitter
1 participant
@davep