Golang 1.8 - Use ClientTrace.TLSHandshakeStart and TLSHandshakeDone

[wendigo]

Use ClientTrace.TLSHandshakeStart/HandshakeDone from incoming go 1.8: golang/go@abdd73c

This PR probably should be blocked until 1.8 is released

[davecheney]

Thanks for sending this. TBH I'm not going to look at this until 1.8 is out at the end of the year, and even then might ask you for a solution to keep backwards compat with go 1.7.

[davecheney]

Also, please raise an issue before slinging code. Thank you.

[wendigo]

Off-topic question @davecheney: what's your recommended approach to using version-specific golang APIs? Should it be avoided and support for previous golang versions must be provided or is it ok to use the most recent version when building and distributing open source software?

[davecheney]

Generally you have to break out the affected function and then implement it
twice with // +build tags

On Sun, Oct 23, 2016 at 9:11 PM, Mateusz Gajewski [email protected]
wrote:

Off-topic question @davecheney https://github.com/davecheney: what's
your recommended approach to using version-specific golang APIs? Should it
be avoided and support for previous golang versions must be provided or is
it ok to use the most recent version when building and distributing open
source software?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#114 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAcA2TnLUNcEOfPQfpH7ONVEnCIj6Jxks5q2zLsgaJpZM4Kd6bM
.

[davecheney]

As for the question about should you use the latest version of Go -- yes,
you should always use the latest version of Go; previous ones have more
bugs and are not supported.

On Sun, Oct 23, 2016 at 9:27 PM, Dave Cheney [email protected] wrote:

Generally you have to break out the affected function and then implement
it twice with // +build tags

On Sun, Oct 23, 2016 at 9:11 PM, Mateusz Gajewski <
[email protected]> wrote:

Off-topic question @davecheney https://github.com/davecheney: what's
your recommended approach to using version-specific golang APIs? Should it
be avoided and support for previous golang versions must be provided or is
it ok to use the most recent version when building and distributing open
source software?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#114 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAcA2TnLUNcEOfPQfpH7ONVEnCIj6Jxks5q2zLsgaJpZM4Kd6bM
.

[wendigo]

Related to #113

[inkel]

Now that Go 1.8 is out, this would be nice to have merged.

[rs]

The .travis needs to be updated to use Go 1.8 so the CI don't fail. Then I guess @davecheney should be able to merge this.

[davecheney]

I’d rather a PR that updated the Travis setting to not test against 1.8. It’s not supported by the Go team, so we shouldn’t either

…

On 28 Apr 2018, at 05:34, Olivier Poitrey ***@***.***> wrote: The .travis needs to be updated to use Go 1.8 so the CI don't fail. Then I guess @davecheney should be able to merge this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.