Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup-DbaDbCertificate, new FileBaseName parameter #9597

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

niphlod
Copy link
Contributor

@niphlod niphlod commented Feb 22, 2025

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes Backup-DbaDbCertificate - Support Custom Backup File Name #9485 )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (Invoke-ManualPester)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Was not convinced myself but the latest point from @serenefiresiren hit the spot, i.e. "I need my own structure because when restoring it's easier if I maintain my own conventions". Thinking of a disaster event, quick spotting of what cert has what name and ends up named by whatever convention is established is not a big deal and, frankly, it's not a mega-modification that needs certain care.

Approach

Just trust the passed parameter that overrides the default naming, and slap a regression test to make sure the feature stays in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backup-DbaDbCertificate - Support Custom Backup File Name
1 participant