ci: switch to codecov cli on appveyor #757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adswa
force-pushed
the
codecov
branch
9 times, most recently
from
f838099
to
bd9fc7b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
===========================================
- Coverage 92.19% 48.87% -43.33%
===========================================
Files 185 185
Lines 14184 14184
Branches 2129 2129
===========================================
- Hits 13077 6932 -6145
- Misses 833 6872 +6039
- Partials 274 380 +106 ☔ View full report in Codecov by Sentry. |
adswa
force-pushed
the
codecov
branch
3 times, most recently
from
adc9724
to
ca935d5
Compare
This change replaces the legacy codecov uploader on macos with a specific codecov-cli (the uploader's modern replacement) version that is known to support several CPUs. This does not solve the issue that coverage reports are not uploaded to codecov, but it fixes the issue that the CPU mismatch caused a non-zero exit code that would lead to a CI failure even when all tests passed. Fixes datalad#756
|
Thanks for starting this effort. I am closing this PR now, because I have extended the approach here to all platforms in #752 and it seems to be working properly. A token for codecov is now needed unconditionally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the macos codecov uploader that failed with a CPU mismatch with the codecov-cli, which is supposed to be a replacement. See #756 for the background exploration