add version handling #103
add version handling #103
Conversation
check for upload and remove not working
| @@ -152,6 +161,8 @@ def checkpresent(self, key): | |||
| return False | |||
|
|
|||
| def transfer_store(self, key, local_file): | |||
| if not self.dataset_version == ':latest': | |||
There was a problem hiding this comment.
This and line 205 are not working.
There was a problem hiding this comment.
Well it seems to work. Only datalad push is ignoring Exceptions?
There was a problem hiding this comment.
When no exception is raised datalad push actually works and a DRAFT is created on dataverse.
The log is exactly the same when it fails. It still says it succeeded but nothing changed on dataverse:
publish(ok): . (dataset) [refs/heads/git-annex->origin:refs/heads/git-annex 62d6084..a5c49a4]
publish(ok): . (dataset) [refs/heads/master->origin:refs/heads/master 424537b..37ed9ae]
action summary:
publish (ok: 2)
There was a problem hiding this comment.
It seems to work when the files handled by annex are pushed
It does not work when it's a git remote.
Steps to reproduce:
git clone "datalad-annex::?type=external&externaltype=dataverse&encryption=none&url=http://localhost:8080/&doi=doi:10.5072/FK2/JSUZ6P" directory
cp filexy directory ``cd directory
datalad save && datalad push --to origin
There was a problem hiding this comment.
I suppose that is misleading, because you pushed that before, right? Hence, git-annex knows the file is there already and doesn't even try to TRANSFER-STORE. Needs to be fresh and with no pushed content yet.
There was a problem hiding this comment.
To clarify: If you look and the results, it's only two: one for each branch pushed. No content pushed whatsoever, and no error reported from annex. Hence this push call didn't even try.
There was a problem hiding this comment.
Yeah there are no new files since only the datalad metadata gets uploaded. Which are just these two files which are changed when new files are saved into the datalad instance.
I am not sure if this really is not an issue
There was a problem hiding this comment.
Ok, that doesn't look right indeed. I'll have a look at it on Monday!
Thanks a ton so far!
|
Oh and this should be tested on a dataverse with a sibling created. I was only able to test it on dataverse datasets which is either used for the git files or the annex files. Not both |
|
Just to leave a note: I have resumed development and I am planing to look into this soon. I have also noticed the improper behavior of I have started to RF the code quite a bit, so I am not sure how easy it would be to simply reapply your changes. However, I will make sure to try and credit you nevertheless should I have to implement this in another way. |
check for upload and remove not working