Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for configurable REGISTRY_URL to download Databricks CLI from custom registrie #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GezimSejdiu
Copy link

Description:

This pull request introduces support for specifying a custom REGISTRY_URL in the GitHub Action to download the Databricks CLI from either the default GitHub registry or a private/custom registry (e.g., Artifactory or another mirror).

Key Changes:

  1. New registry_url Input:

    • Added a new input parameter registry_url to the GitHub Action.
    • This parameter allows users to define a custom registry URL for downloading the Databricks CLI. If no value is provided, it defaults to https://github.com.

    Example Usage:

       - uses: databricks/setup-cli@main
         with:
            version: 0.221.1
            registry_url: 'https://your-private-registry.com/artifactory'
  2. Default to GitHub:

    • If no registry_url is passed, the GitHub Action will automatically use https://github.com for downloading the Databricks CLI.
  3. Updated Bash Script (setup_release.sh):

    • The script now dynamically uses the REGISTRY_URL input to download the Databricks CLI. If the REGISTRY_URL is not provided, the download will default to GitHub.
  4. Backward Compatibility:

    • This change is fully backward-compatible. If no custom registry_url is specified, the GitHub Action will behave exactly as before, pulling the Databricks CLI directly from GitHub.

Why This Change is Important:

  • Flexibility: This enhancement allows users to download the Databricks CLI from private mirrors or registries, which can be useful in environments where access to external resources like GitHub is restricted.

  • Default Behavior Intact: The default behavior remains the same, ensuring that users who do not require a custom registry will continue downloading from GitHub without any additional configuration.

Let me know if you'd like any adjustments or if there are specific points to elaborate further!

…from private registries

- Added  input to allow downloading the Databricks CLI from a configurable registry.
- Defaulted  to  for backward compatibility.
- Updated bash scripts to use  for dynamic CLI downloading.
- Ensures flexibility for using private mirrors or Artifactory instances.
…I download

- Fixed a typo by adding a missing trailing slash to the `REGISTRY_URL` in the `curl` command.
- Ensures proper URL construction when downloading the Databricks CLI from custom registries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant