Properly skip request placeholder types #577
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a way to list types that are not mere request placeholders, so that Python SDK keyed args UX is not cluttered with the types of no use.
mgyucht
reviewed
Aug 10, 2023
Comment on lines
+210
to
+219
| for _, e := range svc.Package.types { | ||
| for _, f := range e.fields { | ||
| if f.Entity == request { | ||
| // this type is not only a request placeholder, but is also | ||
| // part of other type definitions. | ||
| isOnlyUsedAsRequest = false | ||
| } | ||
| } | ||
| } | ||
| request.IsRequestOnly = isOnlyUsedAsRequest |
There was a problem hiding this comment.
Doesn't this need to be done as a postprocessing step? The order in which requests are defined is arbitrary AFAIK, so this could accidentally set types as request only if their uses are not yet processed
There was a problem hiding this comment.
Doesn't this need to be done as a postprocessing step?
it could be in NonPlaceholderTypes() method. may add some false positives, but will try that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to list types that are not mere request placeholders, so that Python SDK keyed args UX is not cluttered with the types of no use.
To be verified after databricks/databricks-sdk-py#264 is merged