Skip to content

ci: Move check to self-hosted runners #5726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 6, 2022
Merged

ci: Move check to self-hosted runners #5726

merged 8 commits into from
Jun 6, 2022

Conversation

everpcpc
Copy link
Member

@everpcpc everpcpc commented Jun 1, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Changelog

  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #issue

@vercel
Copy link

vercel bot commented Jun 1, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Jun 6, 2022 at 3:11AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@everpcpc everpcpc changed the title chore: try cleanup more github action runner space chore: cleanup more github action runner space Jun 1, 2022
@everpcpc everpcpc force-pushed the fix-clean-disk branch 3 times, most recently from eb5f840 to ec73ecb Compare June 3, 2022 02:33
@Xuanwo
Copy link
Member

Xuanwo commented Jun 3, 2022

#5759 is trying to fix this issue in another way.

Move check and unit_test to our self-host runners. (fix the one who raises the problem!)

@Xuanwo
Copy link
Member

Xuanwo commented Jun 3, 2022

Our self-hosted runner has 1min quicker than github's.

@Xuanwo Xuanwo mentioned this pull request Jun 3, 2022
Closed
@Xuanwo
Copy link
Member

Xuanwo commented Jun 3, 2022

unit tests can move to self-hosted runners too.

@Xuanwo
Copy link
Member

Xuanwo commented Jun 4, 2022

Before：

image

This PR：

image

@Xuanwo Xuanwo changed the title chore: cleanup more github action runner space ci: Move check and unittests to self-hosted runners Jun 4, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Jun 4, 2022

image

Seems the runner is OOM. Maybe we need to increase the memory limit.

@everpcpc everpcpc changed the title ci: Move check and unittests to self-hosted runners ci: Move check to self-hosted runners Jun 6, 2022
@everpcpc
Copy link
Member Author

everpcpc commented Jun 6, 2022

We need a Kubernetes feature in 1.23 (https://kubernetes.io/docs/concepts/storage/ephemeral-volumes/#generic-ephemeral-volumes) for better handling ephemeral volumes, which is not currently available in EKS.
EKS seems to release 1.23 by the end of the month, we will migrate unit test then.

@everpcpc everpcpc marked this pull request as ready for review June 6, 2022 01:22
@mergify mergify bot merged commit 970e75b into databendlabs:main Jun 6, 2022
@everpcpc everpcpc deleted the fix-clean-disk branch June 6, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE PsiACE approved these changes

Assignees
No one assigned
Labels
need-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@everpcpc @Xuanwo @PsiACE @databend-bot