Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex support to --xfails-file #344

Closed
wants to merge 1 commit into from

Conversation

crusaderky
Copy link
Contributor

@ev-br
Copy link
Member

ev-br commented Feb 26, 2025

Before trying to understand how it works, I'd like to understand how it is meant to help data-apis/array-api-compat#253. Mind elaborating please @crusaderky ?

@crusaderky
Copy link
Contributor Author

The original intent was to add to the xfails file

.*not implemented for 'UInt16'

However I now realise that

  • this PR wouldn't achieve that: the match is on test name+parametrize; not on error raised
  • the dtype iteration is performed by hypothesis and not by parametrize which means ignoring such an error would neuter the test for all other dtypes.

@crusaderky crusaderky closed this Feb 26, 2025
@crusaderky crusaderky deleted the regex branch February 27, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants