array-api-strict flags #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flags are global variables that set array-api-strict in a specific mode. Currently support flags change the support array API standard version, enable or disable data-dependent shapes, and enable or disable optional extensions. This commit only sets up the structure for setting and getting these flags.
This behavior still needs to be tested. This required moving the linalg functions that are also in the main namespace so that they can still work there even when the linalg extension is disabled. The way I've decided to implement this is that the functions will not raise an exception until they are called. It would probably be more convenient for users if they raised an attribute error, or if the extension namespace itself did, like it would in a real library without the given extension. But the implementation for this would be a lot more complicated and didn't really feel worth it to me.
rgommers
reviewed
Apr 16, 2024
array_api_strict/_flags.py
Outdated
| shapes depend on the input data. | ||
|
|
||
| This flag is enabled by default. Array libraries that use computation graphs may not be able to support | ||
| functions whose output shapes depend on the input data. |
There was a problem hiding this comment.
stray sentence, duplicate with paragraph above
|
@asmeurer I think the |
This matches the name used in __array_namespace__
Closed
|
This is ready to go. I'm not going to implement anything for 2021.12 unless someone requests it. But using this, I can add preliminary support for 2023.12. One thing I'm not completely sure about is if someone sets a flag using an environment variable, like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flags are global variables that set array-api-strict in a specific mode. Currently support flags change the support array API standard version, enable or disable data-dependent shapes, and enable or disable optional extensions.
So far I have only set up the structure for setting and getting these flags. Let me know if this seems like a good API layout or not.
I plan to add functionality to the various functions to enable/disable behaviors depending on what flags are set.
Fixes #8
Fixes #7