Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define complex scalar <op> float array #121

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Jan 29, 2025

This is a companion to data-apis/array-api#871

The volume of workarounds to make tests pass is not bad bad bad, but is probably worth a longer look.
Maybe array._promote_scalar needs to grow a flag to tell whether mixing complex and floats is allowed for a specific caller.

@ev-br ev-br marked this pull request as draft February 5, 2025 14:08
@ev-br ev-br marked this pull request as ready for review February 5, 2025 14:08
@ev-br
Copy link
Member Author

ev-br commented Feb 6, 2025

data-apis/array-api#871 is merged

@ev-br ev-br requested review from betatim and asmeurer February 6, 2025 09:14
@ev-br ev-br merged commit f88f7a8 into data-apis:main Feb 18, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant