BUG: Don't import helpers in namespaces #302
Open
+7
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
force-pushed
the
import_helpers
branch
from
6c4a75d to
65fd5f4
Compare
crusaderky
commented
Apr 3, 2025
| @@ -174,3 +174,5 @@ def trace( | |||
| 'svd', 'cholesky', 'matrix_rank', 'pinv', 'matrix_norm', | |||
| 'matrix_transpose', 'svdvals', 'vecdot', 'vector_norm', 'diagonal', | |||
| 'trace'] | |||
|
|
|||
| _all_ignore = ['math', 'normalize_axis_tuple', 'get_xp', 'np', 'isdtype'] | |||
There was a problem hiding this comment.
No idea why test_all wasn't failing before.
crusaderky
force-pushed
the
import_helpers
branch
from
65fd5f4 to
2c1cb6b
Compare
crusaderky
changed the title
|
This is ready for review. |
crusaderky
commented
Apr 3, 2025
| @@ -276,7 +276,7 @@ def test_asarray_copy(library): | |||
| is_lib_func = globals()[is_array_functions[library]] | |||
| all = xp.all if library != 'dask.array' else lambda x: xp.all(x).compute() | |||
|
|
|||
| if library == 'numpy' and xp.__version__[0] < '2' and not hasattr(xp, '_CopyMode') : | |||
| if library == 'numpy' and xp.__version__[0] < '2' and not hasattr(np, "_CopyMode"): | |||
There was a problem hiding this comment.
FYI this is for numpy 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove helper functions from wrapped array namespaces.
This was introduced when the numpy namespace was split from the helpers in 2022 (b3a12d9).
This PR prompted by a collision between
array_api_compat.deviceandtorch.device.Re. deprecation layer: unsure if we need one? This was never advertised in the documentation.