Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: bump to ndonnx 0.10.1 #297

Merged
merged 1 commit into from
Apr 3, 2025
Merged

TST: bump to ndonnx 0.10.1 #297

merged 1 commit into from
Apr 3, 2025

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Apr 3, 2025

Unbreak my heart CI

@Copilot Copilot bot review requested due to automatic review settings April 3, 2025 09:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates tests to accommodate the updated ndonnx version (0.10.1) by adding conditions to xfail scenarios to match expected behavior changes.

  • Added an xfail condition when converting from torch, dask.array, or jax.numpy to ndonnx.
  • Updated error messages to address dtype inference issues in the new context.
Comments suppressed due to low confidence (1)

tests/test_common.py:245

  • [nitpick] The xfail reason 'unable to infer dtype' is vague; consider providing more context on why dtype inference is failing for these source libraries to support more effective debugging.
elif target_library == "ndonnx" and source_library in ("torch", "dask.array", "jax.numpy"):

@ev-br
Copy link
Member

ev-br commented Apr 3, 2025

While I don't understand what this does or why this is needed, if it helps unbreak the CI, fine. Thanks Guido.

@ev-br ev-br merged commit b6900df into data-apis:main Apr 3, 2025
40 checks passed
@ev-br ev-br added this to the 1.12 milestone Apr 3, 2025
@crusaderky
Copy link
Contributor Author

While I don't understand what this does or why this is needed, if it helps unbreak the CI, fine. Thanks Guido.

It tests asarray calls between backends. Which are not part of the Array API standard, unless the source backend happens to support the buffer protocol.

@crusaderky crusaderky deleted the ndonnx010 branch April 3, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants