Fix clipping float dtypes when either min or max are Python ints #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
clip
no longer crash whenx
has a floating point dtype andmin
and/ormax
are Pythonint
s.The Array API for
clip
states that behavior is unspecified ifx
and eithermin
ormax
have different data type kinds, but I think the change in this PR makes it behave more like what one might expect. This change also makes the code more similar to NumPy's handling of Pythonint
s inclip
.This is my first PR for this repo, hopefully I got it right :) Let me know if I should add anything else.
The work you do with array-api is great, thanks a lot!