Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST Fixes random seed for flaky test_keras #800

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thomasjpfan
Copy link
Contributor

Follow up to #794

I suspect the failing test on main is due to sampling of the parameter space that may lead to scores that are constant.

CC @stsievert

Copy link
Member

@stsievert stsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, random_state is producing the errors. I'm not seeing why else the test would be non-deterministic.

tests/model_selection/test_keras.py Outdated Show resolved Hide resolved
@stsievert
Copy link
Member

Hm.... looks like the error has to do with timeout on windows. I'm not seeing how that's induced by this PR.

@thomasjpfan
Copy link
Contributor Author

thomasjpfan commented Mar 1, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants