Use bit arrays for predicate matching in search. #8684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Apr 1, 2025
| ServiceSearchQuery query, | ||
| IndexedScore<String> packageScores, | ||
| ) { | ||
| // TODO: implement pooling of this object similarly to [ScorePool]. |
There was a problem hiding this comment.
Do you want to do this before landing?
There was a problem hiding this comment.
I think it is better to do it in a subsequent PR, probably coupled with the other TODO.
| (i) => now.difference(_documents[i].updated) > updatedDuration); | ||
| } | ||
|
|
||
| // TODO: find a better way to handle predicate-only filtering and scoring |
There was a problem hiding this comment.
Should we open an issue for this?
| @@ -48,6 +48,7 @@ dependencies: | |||
| # pana version to be pinned | |||
| pana: '0.22.20' | |||
| # 3rd-party packages with pinned versions | |||
| bit_array: 2.3.0 | |||
There was a problem hiding this comment.
@jonasfj are we ok with this dependency?
There was a problem hiding this comment.
Note: the 80% of package:bit_array is probably not needed for pub-dev, and I have no issue with vendoring it.
Also: the package is using 32-bit ints for cross-compatibility in browsers, and it is possible we should benchmark using 64-bit ints for the server-only use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackageScoreinstance when theBitArraywould suffice.