Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for cycle references. #3238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add validation for cycle references. #3238

wants to merge 1 commit into from
+19 −0

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Apr 6, 2025 •
edited
Loading

@polina-c polina-c requested a review from devoncarew April 6, 2025 18:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 6, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️ 
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/samples/lib/brick_breaker.dart
pkgs/samples/lib/fibonacci.dart
pkgs/samples/lib/google_ai.dart
pkgs/samples/lib/hello_world.dart
pkgs/samples/lib/main.dart
pkgs/samples/lib/sunflower.dart

@polina-c polina-c marked this pull request as ready for review April 6, 2025 19:12
devoncarew
devoncarew reviewed Apr 7, 2025
View reviewed changes
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up w/ a CI check! 2-3 comments

pkgs/dartpad_ui/tool/check_cycles.sh

cd $TOOL_DIR/..
dart pub global activate layerlens
layerlens --path . --fail-on-cycles
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can layerlens take a param for which directory to operate on? If so, that would allow us to avoid two cd commands.

pkgs/dartpad_ui/tool/check_cycles.sh
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

# Runs `analyze` for all code in the repo.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this file comment or update it to reference that this script looks for dep cycles.

pkgs/dartpad_ui/tool/check_cycles.sh
@@ -0,0 +1,18 @@
#!/bin/bash

# Copyright 2023 The Chromium Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright 2023 The Chromium Authors. All rights reserved.
# Copyright 2025 The Chromium Authors. All rights reserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polina-c @devoncarew