Skip to content

Ensure DurableTask classes are hidden in Workflow Runtime package #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025

Conversation

artur-ciocanu
Copy link
Contributor

Description

The purpose of this PR is to ensure that we hide all the DurableTask Framework related classes behind runtime package and ensure that we use classes that are free of implementation details.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1310

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artur-ciocanu artur-ciocanu requested review from a team as code owners April 12, 2025 17:36
@artur-ciocanu
Copy link
Contributor Author

@salaboy and @cicoyle could you please take a look and share your thoughts. Thank you.

salaboy
salaboy previously approved these changes Apr 13, 2025
Copy link
Contributor

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed this PR and I am happy to approve, unless @cicoyle has any requested changes I think we should merge it.

Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this refactor 🎉 looks great, just one comment for the header

Signed-off-by: Artur Ciocanu <[email protected]>
@artur-ciocanu
Copy link
Contributor Author

@cicoyle the header is fixed. Could you please approve, thank you!

@artur-ciocanu artur-ciocanu requested a review from cicoyle April 14, 2025 15:38
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank youuu

@cicoyle cicoyle merged commit ef1fc22 into dapr:master Apr 14, 2025
8 of 9 checks passed
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 82.05128% with 14 lines in your changes missing coverage. Please review.

Project coverage is 75.38%. Comparing base (d759c53) to head (1de8237).
Report is 126 commits behind head on master.

Files with missing lines Patch % Lines
...a/io/dapr/workflows/client/DaprWorkflowClient.java 52.63% 2 Missing and 7 partials ⚠️
...rkflows/runtime/DefaultWorkflowInstanceStatus.java 91.30% 1 Missing and 1 partial ⚠️
...kflows/runtime/WorkflowRuntimeStatusConverter.java 83.33% 1 Missing and 1 partial ⚠️
...rkflows/runtime/DefaultWorkflowFailureDetails.java 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1311      +/-   ##
============================================
- Coverage     76.91%   75.38%   -1.54%     
- Complexity     1592     1605      +13     
============================================
  Files           145      194      +49     
  Lines          4843     5090     +247     
  Branches        562      559       -3     
============================================
+ Hits           3725     3837     +112     
- Misses          821      933     +112     
- Partials        297      320      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@artur-ciocanu artur-ciocanu deleted the gh-1310 branch April 14, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup workflow public interface from DurableTask dependencies
4 participants