-
Notifications
You must be signed in to change notification settings - Fork 215
Ensure DurableTask classes are hidden in Workflow Runtime package #1311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Artur Ciocanu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed this PR and I am happy to approve, unless @cicoyle has any requested changes I think we should merge it.
sdk-workflows/src/main/java/io/dapr/workflows/runtime/DefaultWorkflowInstanceStatus.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this refactor 🎉 looks great, just one comment for the header
sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntimeStatusConverter.java
Show resolved
Hide resolved
Signed-off-by: Artur Ciocanu <[email protected]>
@cicoyle the header is fixed. Could you please approve, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank youuu
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1311 +/- ##
============================================
- Coverage 76.91% 75.38% -1.54%
- Complexity 1592 1605 +13
============================================
Files 145 194 +49
Lines 4843 5090 +247
Branches 562 559 -3
============================================
+ Hits 3725 3837 +112
- Misses 821 933 +112
- Partials 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
The purpose of this PR is to ensure that we hide all the
DurableTask Framework
related classes behindruntime
package and ensure that we use classes that are free of implementation details.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1310
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: