-
Notifications
You must be signed in to change notification settings - Fork 215
Make the DAPR version being used consistent across all tests #1299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Make the DAPR version being used consistent across all tests #1299
Conversation
The tests are failing with scheduler not available. Will wait for Jobs SDK PR to merge and then work on this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siri-varma very nice PR, I have left a tiny comment, could you please address and resend and I will approve.
Thank you!
sdk-tests/src/test/java/io/dapr/it/testcontainers/ContainerConstants.java
Outdated
Show resolved
Hide resolved
testcontainers-dapr/src/main/java/io/dapr/testcontainers/ContainerConstants.java
Outdated
Show resolved
Hide resolved
@siri-varma could you please check the conflicts and address the comments. Thank you. |
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
3ac03e3
to
12f1150
Compare
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1299 +/- ##
============================================
- Coverage 76.91% 76.87% -0.04%
- Complexity 1592 1719 +127
============================================
Files 145 200 +55
Lines 4843 5272 +429
Branches 562 574 +12
============================================
+ Hits 3725 4053 +328
- Misses 821 903 +82
- Partials 297 316 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@artur-ciocanu addressed all the comments and merge conflicts. These changes are ready to review as well |
Description
Make the dapr version being used consistent across all tests
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1296
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: