Skip to content

Make the DAPR version being used consistent across all tests #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

siri-varma
Copy link
Contributor

@siri-varma siri-varma commented Apr 8, 2025

Description

Make the dapr version being used consistent across all tests

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1296

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@siri-varma siri-varma requested review from a team as code owners April 8, 2025 09:56
@siri-varma
Copy link
Contributor Author

The tests are failing with scheduler not available. Will wait for Jobs SDK PR to merge and then work on this PR

Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siri-varma very nice PR, I have left a tiny comment, could you please address and resend and I will approve.

Thank you!

@artur-ciocanu artur-ciocanu mentioned this pull request Apr 8, 2025
3 tasks
@artur-ciocanu
Copy link
Contributor

@siri-varma could you please check the conflicts and address the comments. Thank you.

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
@siri-varma siri-varma force-pushed the users/svegiraju/make-version-consistent branch from 3ac03e3 to 12f1150 Compare April 17, 2025 07:01
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.87%. Comparing base (d759c53) to head (8449c53).
Report is 129 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/io/dapr/testcontainers/DaprContainer.java 50.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1299      +/-   ##
============================================
- Coverage     76.91%   76.87%   -0.04%     
- Complexity     1592     1719     +127     
============================================
  Files           145      200      +55     
  Lines          4843     5272     +429     
  Branches        562      574      +12     
============================================
+ Hits           3725     4053     +328     
- Misses          821      903      +82     
- Partials        297      316      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@siri-varma
Copy link
Contributor Author

@artur-ciocanu addressed all the comments and merge conflicts.

These changes are ready to review as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure one single dapr runtime version is used across all the integration tests
2 participants