Use Network.newNetwork() to create a Docker Network #1273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sirivarma <[email protected]>
|
@artur-ciocanu , @salaboy , @cicoyle I just saw other non flaky tests use this pattern of creating a network. So changed this test to match that pattern as well. Let me know your thoughts |
Signed-off-by: sirivarma <[email protected]>
siri-varma
changed the title
…iri-varma/java-sdk into users/svegiraju/fix-flaky-test
|
@siri-varma we cannot use |
salaboy
requested changes
Mar 21, 2025
salaboy
reviewed
Mar 21, 2025
| } else { | ||
| return defaultDaprNetwork; | ||
| } | ||
| return Network.newNetwork(); |
There was a problem hiding this comment.
@siri-varma this would have been so much easier.. but we cannot do that if we want to run both applications locally to reuse the network.
|
@siri-varma can you please close this one? |
|
Synced up with @salaboy and looks like he is already working on it. Will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From the logs it is not able to find "dapr-network"
The other nonflaky tests inside testcontainers just use Network.newNetwork(). So changed this to use the same pattern
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1248
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: