Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support App HTTP middleware Pipelines #1271

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

salaboy
Copy link
Contributor

@salaboy salaboy commented Mar 20, 2025

Description

Add support for configuring AppHTTPMiddleware pipelines for testcontainers.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1270

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@salaboy salaboy requested review from a team as code owners March 20, 2025 14:30
@salaboy salaboy force-pushed the 1270-app-middleware branch 2 times, most recently from b0abc03 to d608392 Compare March 20, 2025 14:31
@salaboy salaboy self-assigned this Mar 20, 2025
@salaboy salaboy added this to the v1.15 milestone Mar 20, 2025
@salaboy salaboy marked this pull request as draft March 20, 2025 14:31
@salaboy salaboy force-pushed the 1270-app-middleware branch from 4992bb9 to 2300d66 Compare March 20, 2025 14:47
@salaboy salaboy marked this pull request as ready for review March 20, 2025 14:47
@salaboy salaboy changed the title [WIP] Support App HTTP middleware Pipelines Support App HTTP middleware Pipelines Mar 20, 2025
@salaboy
Copy link
Contributor Author

salaboy commented Mar 20, 2025

@artur-ciocanu @mcruzdev1 @cicoyle please review. This add the support the AppHttpMiddlewarePipeline to support microcks contract tests paths.

@salaboy salaboy force-pushed the 1270-app-middleware branch from 82b5d81 to 8172780 Compare March 20, 2025 14:55
@mcruzdev
Copy link
Contributor

Hi @salaboy, could you add a simple context about this solution to me?

@salaboy
Copy link
Contributor Author

salaboy commented Mar 21, 2025

Ok, a bit of context:

  • AppHttpPipelines middleware allows us to change the behaviour of incoming and outgoing requests from the Dapr sidecar. This PR adds support for configuring these middleware pipelines.
  • This is needed to support service-to-service contract testing using microcks.io, something that we need if we want to simplify how to test multiple Dapr-enabled applications.

The main requirement here is to have a consistent story to test Spring Boot Dapr-enabled applications that use Service to Service communication (which requires two sidecars to communicate) in test scenarios, where instead of starting a second service we can use contract testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support App Middleware configuration for Testcontainers
2 participants