Add actor testcontainer tests

[akkie]

Description

This PR adds testcontainer based integration tests for actors. This is to make sure that actors really work with testcontainers.

Issue reference

This PR was crated based on a Discord discussion with @salaboy to check if actors works with testcontainers.

[akkie]

@salaboy I have currently the problem that the test fails with the following exception when trying to connect to the Dapr gRPC port.

Caused by: io.grpc.netty.shaded.io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: /127.0.0.1:50001
Caused by: java.net.ConnectException: Connection refused
        at java.base/sun.nio.ch.Net.pollConnect(Native Method)
        at java.base/sun.nio.ch.Net.pollConnectNow(Net.java:682)
        at java.base/sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:1062)
        at io.grpc.netty.shaded.io.netty.channel.socket.nio.NioSocketChannel.doFinishConnect(NioSocketChannel.java:336)
        at io.grpc.netty.shaded.io.netty.channel.nio.AbstractNioChannel$AbstractNioUnsafe.finishConnect(AbstractNioChannel.java:339)
        at io.grpc.netty.shaded.io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:776)
        at io.grpc.netty.shaded.io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724)
        at io.grpc.netty.shaded.io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650)
        at io.grpc.netty.shaded.io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562)
        at io.grpc.netty.shaded.io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:994)
        at io.grpc.netty.shaded.io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
        at io.grpc.netty.shaded.io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
        at java.base/java.lang.Thread.run(Thread.java:1575)

Not sure why it uses port 50001, because this is the internal port. I think normally it should use the mapped port. Maybe you can have a look, if the test is not correct configured?

[salaboy]

@akkie thanks a lot of this.. give me some time to look into this.. check the DCO, we need that to approve the PR. Click on the Details link to see the steps to fix it.

[akkie]

@salaboy Is it OK if I do a force push regarding the update of the DCO?

[salaboy]

@akkie yeah.. that is your fork.. so it is ok

[salaboy]

@akkie would you mind adding me as a collaborator to your fork? I am working on a fix, but I would love to push to your fork.. if not I can send you a patch to apply to your fork with the fix

[akkie]

@akkie would you mind adding me as a collaborator to your fork? I am working on a fix, but I would love to push to your fork.. if not I can send you a patch to apply to your fork with the fix

Done

[salaboy]

@akkie I will push two commits to your fork, I am stuck with a new error now.. but at least the connection is working now.

[salaboy]

Now I am stuck with this:

time="2025-01-22T17:41:56.55236659Z" level=debug msg="api error: code = Internal desc = error invoke actor method: did not find address for actor TestActor/f5893dd3-9d9c-4405-859e-b0c3b6aa2988" app_id=actor-dapr-app instance=780ae8017e66 scope=dapr.runtime.grpc.api type=log ver=1.14.1


io.dapr.exceptions.DaprException: INTERNAL: error invoke actor method: did not find address for actor TestActor/f5893dd3-9d9c-4405-859e-b0c3b6aa2988

But the connection is working as far as I can tell.

[salaboy]

This is strange.. because it looks like we are hitting this: dapr/dapr#6783

https://github.com/dapr/java-sdk/blob/master/examples/src/main/java/io/dapr/examples/actors/DemoActorClient.java

@artursouza do you know if these examples are executed as part of the tests?

[akkie]

@salaboy This is exactly the message we get with our testcontainer setup:

fails to send binding event to http app channel, status code: 500 body: Dapr.DaprApiException: error invoke actor method: did not find address for actor

We use .NET and not Java.

[salaboy]

Ok so I think we are up to something here - Blog: http://salaboy.com <http://salaboy.wordpress.com> - Github user: http://github.com/salaboy - Twitter: http://twitter.com/salaboy - Mauricio "Salaboy" Salatino -

…

On Wed, 22 Jan 2025 at 20:11, Christian Kaps ***@***.***> wrote: @salaboy <https://github.com/salaboy> This is exactly the message we get with our testcontainer setup: ´´´ fails to send binding event to http app channel, status code: 500 body: Dapr.DaprApiException: error invoke actor method: did not find address for actor ´´´ We use .NET and not Java. — Reply to this email directly, view it on GitHub <#1192 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACCMXUKSIIUSSF7NQM2YJT2L73O5AVCNFSM6AAAAABVI4UL56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBYGE3TANRUHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[salaboy]

@akkie I am curious.. are you testing with an in-memory statestore?

[akkie]

@salaboy Yes, we are using Redis.

[salaboy]

@akkie if you pull the code that I push can you check that you are getting the same results?

[akkie]

@salaboy You mean running the tests? If I run them, yes, I get the same result:

time="2025-01-23T15:27:19.585808881Z" level=debug msg="api error: code = Internal desc = error invoke actor method: did not find address for actor TestActor/7b7f7132-b3ab-4789-97d6-7dd9cfe6401d" app_id=actor-dapr-app instance=987309611b00 scope=dapr.runtime.grpc.api type=log ver=1.14.1

[salaboy]

@akkie good news.. i think that I found the issue..
From what I can see there are two different things:

1. We need to configure the app-port so the sidecar can contact back the application when it needs to execute an actor
2. The actor runtime where we need to register actors (ActorRuntime.getInstance().registerActor(TestActorImpl.class);) is the one that is failing to get the right port. Because it is creating a new grpc channel without the overrides needed to connect to testcontainers..

I will try to fix this and push again.

[akkie]

@salaboy Any news regarding the issue?

[salaboy]

I am still fighting with this.. for some Reason after fixing all the connection issues, the actor is not registered in the placement service. I am trying to figure out why - Blog: http://salaboy.com <http://salaboy.wordpress.com> - Github user: http://github.com/salaboy - Twitter: http://twitter.com/salaboy - Mauricio "Salaboy" Salatino -

…

On Thu, 30 Jan 2025 at 10:12, Christian Kaps ***@***.***> wrote: @salaboy <https://github.com/salaboy> Any news regarding the issue? — Reply to this email directly, view it on GitHub <#1192 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACCMXUL5XKLZCHGK7LKWE32NH3JFAVCNFSM6AAAAABVI4UL56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRUGA2TQNZRGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[salaboy]

The funny thing is that the actor example in the Java SDK is working , but that example uses two sidecars instead of one.. and I am not entirely sure if that placement service is configured differently - Blog: http://salaboy.com <http://salaboy.wordpress.com> - Github user: http://github.com/salaboy - Twitter: http://twitter.com/salaboy - Mauricio "Salaboy" Salatino -

…

On Thu, 30 Jan 2025 at 10:59, Mauricio Salatino ***@***.***> wrote: I am still fighting with this.. for some Reason after fixing all the connection issues, the actor is not registered in the placement service. I am trying to figure out why - Blog: http://salaboy.com <http://salaboy.wordpress.com> - Github user: http://github.com/salaboy - Twitter: http://twitter.com/salaboy - Mauricio "Salaboy" Salatino - On Thu, 30 Jan 2025 at 10:12, Christian Kaps ***@***.***> wrote: > @salaboy <https://github.com/salaboy> Any news regarding the issue? > > — > Reply to this email directly, view it on GitHub > <#1192 (comment)>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AACCMXUL5XKLZCHGK7LKWE32NH3JFAVCNFSM6AAAAABVI4UL56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRUGA2TQNZRGY> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[artur-ciocanu]

@salaboy and @akkie I have found what's the culprit. Please check #1202. The TL;DR is that ActorRuntime doesn't allow properties override and that is why we see default GRPC port in logs and issues like actors not being found.

I will try to have a quick fix just to unblock this PR, but in general I think ActorRuntime should be aligned with WorkflowRuntime design for consistency sake.

CC: @artursouza @cicoyle

[artur-ciocanu]

@akkie and @salaboy overall looks great, but there are some weird formatting issues that would be nice to address.

I think checkstyle will complain about it.

[akkie]

@artur-ciocanu Thanks for working on that. I fixed the formatting issues. Is there anything I need to do to get the tests running locally? They still failing for me with the message: api error: code = Internal desc = error invoke actor method: did not find address for actor TestActor/789215ad-9328-4019-8c86-6a4b6cc664a7

[salaboy]

@akkie I think we are hitting the same issue as we hit with PubSub.. we need to investigate this further.. My expectation is that if we run this application in a Kubernetes Cluster, everything works.. so the issue is related with the sequence in which both the app and the sidecar gets bootstrapped by testcontainers.
I've created these examples for other features: #1208; we should add an actor Example there and run the applications locally to see if the issue exists outside of the test containers setup.

[cicoyle]

CI is green and while the port overriding is not the prettiest, it works.

[jakesmolka]

@jakesmolka could you please the comments in this PR. As far as I remember you have mentioned that using Spring Boot Test with a defined port was problematic. I think we have found a way, it is not ideal, but it should work.

I wonder what are your thoughts.

Hey, thanks for letting me know @artur-ciocanu. I don’t have much time right now but gladly check it out later.

[artur-ciocanu]

@artursouza could you please take a look and approve it. Thank you!

[artur-ciocanu]

@artursouza and @cicoyle we need your review one more time. Thank you!

[artur-ciocanu]

Great job! Love it!