Improvement of dapr-doc #1084
Merged
Improvement of dapr-doc #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubhdeep Singh <[email protected]>
Signed-off-by: Shubhdeep Singh <[email protected]>
|
/LGTM but maybe someone with more experience can verify that we want this information in those md files. I think it is helpful for contributors |
|
@artursouza please review the PR |
cicoyle
reviewed
Jul 25, 2024
cicoyle
reviewed
Jul 25, 2024
mikeee
reviewed
Jul 29, 2024
|
@Shubhdeep02 please review the above suggestions |
|
@cicoyle i'll just open a new PR keeping above suggestions in check |
bashlion
approved these changes
Jan 1, 2025
|
ping @Shubhdeep02 can you apply the suggestions? I don't think a new PR is necessary, as we can use this one. Please lmk if you need assistance. Thanks! |
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: salaboy <[email protected]>
|
Thanks @Shubhdeep02 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvement for contributing.md files
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Resolves Document That Users Can Self-Assign Issues #926