Add JavaTimeModule

[mcruzdev]

Description

Please explain the changes you've made

Issue reference

#995

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Extended the documentation

[cicoyle]

Ping @mcruzdev were you still working on this?

[mcruzdev]

Hi @cicoyle to be sincerous no, but I would like to continue, do you think to get this one?

[mcruzdev]

I need to add tests and probably to upgrade the dependency version

[mcruzdev]

Hi @cicoyle, sorry for delay... I think this one solve the issue.

I tested calling the invokeMethod withouth JavaTimeModule and the error was reproduced.

[mcruzdev]

Hi @cicoyle @salaboy, am I in the right path, WDYT?

[salaboy]

@artursouza can you check this? I am not sure to have the full context to evaluate these changes.. but looking at the code it looks ok to me. Do we want to have that new dependency in the SDK? I am ok with it.

[artur-ciocanu]

@mcruzdev thank you for your contribution, it looks really good!

[artur-ciocanu]

@mcruzdev as I was thinking about your PR, it occurred to me that there could be a lot of other instances where we would like to register a custom Jackson module. My suggestion is to see how can we expand the ObjectSerializer API a little bit and maybe adding a ObjectSerializerFactory with two methods:

• ObjectSerializerFactory.createDefaultSerializer() - this will create the default serializer that is currently used everywhere
• ObjectSerializerFactory.createJacksonSerializer(ObjectMapper om) - this will be used to create a Jackson based serialized where we can customize the ObjectMapper and ensure we can add or remove all the necessary modules

CC: @cicoyle @artursouza

[mcruzdev]

Good suggestions @artur-ciocanu TY, I will update the PR.

[mcruzdev]

Hi @artur-ciocanu, could you take a new review?

[artur-ciocanu]

@mcruzdev thanks a lot for the updates, I have provided some additional comments, also I think it would make sense to provide some examples on how anyone could customize the serializers.

I think it would make sense to have a separate unit test for CustomizableObjectSerializer where we could show how one could customize the serializer and how ZonedDateTime would be serialized using Jackson JavaTimeModule

[artur-ciocanu]

@mcruzdev thanks for contribution, love it. I have left a few tiny comments.

[artur-ciocanu]

@cicoyle and @salaboy could you also please take a look? Thank you.

[artur-ciocanu]

Awesome job! 👍

[artur-ciocanu]

@cicoyle I think this PR looks great and it is a good example on how anyone can extend the DaprObjectSerializer to add other Jackson modules, this was a huge pain in the past.

Could you please review and approve. Thank you!

[artur-ciocanu]

Approving for CI

[artur-ciocanu]

@cicoyle could you please approve this PR. Thank you.

[salaboy]

LGTM ! thanks @mcruzdev !

[salaboy]

retriggering CI but this is ready to be merged @cicoyle

[artur-ciocanu]

@cicoyle could you please approve and merge this PR. Thank you.

[cicoyle]

Thanks @mcruzdev 🎉