Add client unit test #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Kai <[email protected]>
@danyalprout @bitwiseguy For testing replayor, I thought it need mocked execution node which provide Eth API and Engine API. What is the better approach to do this? I knew there are some in-process mocks using in the action tests in optimism-mono repo, and another way such as running the real node using docker/kurtosis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope to use this PR to discuss that for setupclients, a simple mock of ethnode and engineapi is feasible. However, considering that the interfaces used in benchmarking and service tests require a lot of data, it might be better to start a service to mock. Are there any good ways to mock an ethnode with data currently?