-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get an array of results from GPT #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#164 follow-up; data update: oldnyc/oldnyc.github.io@2c8e18d
Coder
protocol to return a list ofLocatable
s (could be a generator in the future).This creates a few new failure modes. A notable one is that the rare photographer who includes their address in the byline becomes a major problem, since I give addresses precedence over place names. I've manually reviewed all addresses that appear in 2+ items or cause a photo to move 1+ km, but there are almost certainly more unique photographer addresses lurking.
diff_geojson.py
).This is a pretty big diff:
The diff on the truth data doesn't look too hot (+8 wins, +5 losses) but none of the new losses bother me too much. The primary cause is "address pinning", where if I geocode "1234 X St" but the highest address on X St is 789, then Google returns the location of "789 X St." This can happen when the street used to continue farther. I'm hoping that plugging in
nyc-streets.geojson
from the NYPL will help fix this by giving me more historic intersections.TODO (this PR):
geocode.py
Remaining follow-up work: