Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locatable refactor #177

Merged
merged 15 commits into from
Nov 22, 2024
Merged

Locatable refactor #177

merged 15 commits into from
Nov 22, 2024

Conversation

danvk
Copy link
Owner

@danvk danvk commented Nov 21, 2024

At some point the various coders may have handled Google Maps API responses differently, but that time is long passed. This updates the coders to better reflect how they're used today. It will also make it easier to have coders return multiple candidate locations in the future.

I matched the existing (inconsistent) rounding, so there are no data changes in oldnyc.github.io to go along with this.

TODO:

  • Match existing logs
  • Figure out why rounding changed on some locations

@danvk danvk marked this pull request as ready for review November 21, 2024 23:11
@danvk danvk merged commit a9bed15 into master Nov 22, 2024
4 checks passed
@danvk danvk deleted the locatable-refactor branch November 22, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant