-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GPT for geocoding #164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#150; data update: oldnyc/oldnyc.github.io@aea9ddf
I ran all the items that didn't match title-cross or title-address (~17k) through gpt-4o with this prompt:
It cost ~$11 to run this over the 17,000 items.
This is able to replace almost all the remaining matches from the milstein and extended-grid coders. It adds 1979 new items to the site. These are pretty fun to browse through. They're all wins so far as I can tell. The locations tend to come from either complicated patterns in the title, or (more satisfying!) from location information in the backing text that hasn't made it over to the title. A few examples:
There were 382 items that moved. Many of these were wins. A lot of the losses were from GPT misinterpreting titles like "Fifth Avenue #57" as "5th Ave & 57th Street" instead of as an address. This led me to create the title-address coder to handle these directly.
I also added a "special cases" coder to help clean up some oddballs like the China Daily News series and the various Squatters colonies. I think these may have been handled specially when the "Address" column was created back in 2013.
So only 98 items that still fall through to extended-grid and milstein.
Truth data diff:
So that's an all-around win. Thanks, GPT!